feat: support subtractive cell selection - #6476
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (116)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe cell-selection feature now supports ordered include/exclude operations, subtractive modified interactions, explicit range modes, normalized positive regions, and focused excluded cells. Documentation, examples, migration guidance, and tests describe or verify the behavior. ChangesCell selection operations
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant User
participant CellSelectionFeature
participant CellSelectionGeometry
participant SelectionState
User->>CellSelectionFeature: Ctrl/Cmd-click or drag a cell range
CellSelectionFeature->>CellSelectionGeometry: Apply include or exclude bounds
CellSelectionGeometry-->>CellSelectionFeature: Return normalized positive regions
CellSelectionFeature->>SelectionState: Store operation and focus anchor
SelectionState-->>User: Expose selected and focused cell state
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit e877d0f
☁️ Nx Cloud last updated this comment at |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/table-core/src/features/cell-selection/cellSelectionFeature.types.ts (1)
300-305: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
selectCellRange'srangeparameter accepts anoperationfield that has no effect.The public
selectCellRangesignature types itsrangeargument as the fullCellSelectionRange, which includes the optionaloperationfield. The implementation always discards that field and derives the actual operation solely fromopts.mode, defaulting toreplacewhenmodeis omitted. A caller who setsrange.operation: 'exclude'without also passingopts.mode: 'exclude'silently gets a full-selection replace instead of an exclusion. Narrow the public parameter type so this mismatch cannot compile, and keep the stripping logic as the single source of truth.
packages/table-core/src/features/cell-selection/cellSelectionFeature.types.ts#L300-L305: change therangeparameter type onselectCellRangetoOmit<CellSelectionRange, 'operation'>.packages/table-core/src/features/cell-selection/cellSelectionFeature.utils.ts#L566-L572: once the type is narrowed, the{ operation: _operation, ...coordinates }destructuring can be simplified sincerangewill no longer carry anoperationfield to strip.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/table-core/src/features/cell-selection/cellSelectionFeature.types.ts` around lines 300 - 305, Narrow the public selectCellRange parameter in cellSelectionFeature.types.ts:300-305 to Omit<CellSelectionRange, 'operation'> so callers cannot provide an ignored operation field. In cellSelectionFeature.utils.ts:566-572, simplify the range destructuring to use the coordinates directly because operation is no longer part of the accepted range type, while preserving opts.mode as the sole operation source and existing default behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/reference/index/interfaces/SelectCellRangeOptions.md`:
- Around line 29-38: Update the source JSDoc for SelectCellRangeOptions.mode in
the cell-selection type definitions to explicitly state that mode takes
precedence over the deprecated additive option when both are provided, including
that mode: 'exclude' remains subtractive with additive: true. Regenerate the
corresponding SelectCellRangeOptions reference page so the clarification is
reflected in the documentation.
In `@docs/reference/static-functions/functions/table_getCellSelectionBounds.md`:
- Around line 14-15: Update the description of the standalone function reference
for table_getCellSelectionBounds to explicitly state that the returned index
rectangles use inclusive boundaries, matching
Table_CellSelection.getCellSelectionBounds.
In `@docs/reference/static-functions/functions/table_getFocusedCell.md`:
- Line 16: Update the documentation for table_getFocusedCell to clarify that an
exclude operation may leave the focused cell outside the final positive
selection, so callers must not assume the returned cell is selected.
---
Outside diff comments:
In
`@packages/table-core/src/features/cell-selection/cellSelectionFeature.types.ts`:
- Around line 300-305: Narrow the public selectCellRange parameter in
cellSelectionFeature.types.ts:300-305 to Omit<CellSelectionRange, 'operation'>
so callers cannot provide an ignored operation field. In
cellSelectionFeature.utils.ts:566-572, simplify the range destructuring to use
the coordinates directly because operation is no longer part of the accepted
range type, while preserving opts.mode as the sole operation source and existing
default behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: b1280804-87eb-4096-abfb-2feaa3e5d077
📒 Files selected for processing (65)
docs/framework/alpine/guide/cell-selection.mddocs/framework/angular/guide/cell-selection.mddocs/framework/ember/guide/cell-selection.mddocs/framework/lit/guide/cell-selection.mddocs/framework/lit/quick-start.mddocs/framework/preact/guide/cell-selection.mddocs/framework/react/guide/cell-selection.mddocs/framework/solid/guide/cell-selection.mddocs/framework/svelte/guide/cell-selection.mddocs/framework/vue/guide/cell-selection.mddocs/reference/index/index.mddocs/reference/index/interfaces/CellSelectionRange.mddocs/reference/index/interfaces/Cell_CellSelection.mddocs/reference/index/interfaces/SelectCellRangeOptions.mddocs/reference/index/interfaces/TableOptions_CellSelection.mddocs/reference/index/interfaces/Table_CellSelection.mddocs/reference/index/type-aliases/CellSelectionRangeMode.mddocs/reference/index/type-aliases/CellSelectionRangeOperation.mddocs/reference/index/type-aliases/CellSelectionState.mddocs/reference/static-functions/functions/cell_getIsFocused.mddocs/reference/static-functions/functions/cell_getIsSelected.mddocs/reference/static-functions/functions/table_getCellSelectionBounds.mddocs/reference/static-functions/functions/table_getFocusedCell.mddocs/reference/static-functions/functions/table_getSelectedCellCount.mddocs/reference/static-functions/functions/table_getSelectedCellRangesData.mddocs/reference/static-functions/functions/table_selectCellRange.mdexamples/alpine/cell-selection/src/main.tsexamples/angular/cell-selection/src/app/app.htmlexamples/angular/cell-selection/src/app/app.tsexamples/lit/basic-app-table/src/main.tsexamples/lit/basic-dynamic-columns/src/main.tsexamples/lit/basic-external-atoms/src/main.tsexamples/lit/basic-external-state/src/main.tsexamples/lit/basic-subscribe/src/main.tsexamples/lit/cell-selection/src/main.tsexamples/lit/column-pinning-sticky/src/main.tsexamples/lit/column-pinning/src/main.tsexamples/lit/column-sizing/src/main.tsexamples/lit/composable-tables/src/components/products-table.tsexamples/lit/composable-tables/src/components/users-table.tsexamples/lit/expanding/src/main.tsexamples/lit/filters-faceted-bucketed/src/main.tsexamples/lit/filters-faceted/src/main.tsexamples/lit/filters-fuzzy/src/main.tsexamples/lit/filters/src/main.tsexamples/lit/grouped-aggregation/src/main.tsexamples/lit/grouping/src/main.tsexamples/lit/kitchen-sink/src/main.tsexamples/lit/row-pinning/src/main.tsexamples/lit/sorting-dynamic-data/src/main.tsexamples/lit/sorting/src/main.tsexamples/lit/virtualized-columns/src/main.tsexamples/preact/cell-selection/src/main.tsxexamples/react/cell-selection/src/main.tsxexamples/react/cell-selection/tests/e2e/smoke.spec.tsexamples/react/spreadsheet/tests/e2e/spreadsheet.spec.tsexamples/solid/cell-selection/src/App.tsxexamples/svelte/cell-selection/src/App.svelteexamples/vue/cell-selection/src/App.vuepackages/table-core/src/features/cell-selection/cellSelectionFeature.types.tspackages/table-core/src/features/cell-selection/cellSelectionFeature.utils.tspackages/table-core/src/features/cell-selection/cellSelectionGeometry.tspackages/table-core/tests/implementation/features/cell-selection/cellSelectionFeature.test.tspackages/table-core/tests/implementation/features/cell-selection/cellSelectionGeometry.test.tspackages/table-core/tests/implementation/features/cell-selection/cellSelectionRange.test.ts
| ### mode? | ||
|
|
||
| ```ts | ||
| optional mode: CellSelectionRangeMode; | ||
| ``` | ||
|
|
||
| Defined in: [features/cell-selection/cellSelectionFeature.types.ts:79](https://github.com/TanStack/table/blob/main/packages/table-core/src/features/cell-selection/cellSelectionFeature.types.ts#L79) | ||
|
|
||
| Whether to replace the selection, add the range, or subtract the range. | ||
| Defaults to `replace`. |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Document precedence when both options are provided.
mode takes precedence over the deprecated additive flag. State this explicitly so calls such as mode: 'exclude', additive: true are understood as subtractive.
Add the clarification to the source JSDoc and regenerate this reference page.
Proposed clarification
Whether to replace the selection, add the range, or subtract the range.
Defaults to `replace`.
+When provided, `mode` takes precedence over deprecated `additive`.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/reference/index/interfaces/SelectCellRangeOptions.md` around lines 29 -
38, Update the source JSDoc for SelectCellRangeOptions.mode in the
cell-selection type definitions to explicitly state that mode takes precedence
over the deprecated additive option when both are provided, including that mode:
'exclude' remains subtractive with additive: true. Regenerate the corresponding
SelectCellRangeOptions reference page so the clarification is reflected in the
documentation.
| Resolves ordered range operations into disjoint, positive display-order | ||
| index rectangles. |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Document that the bounds are inclusive.
The standalone function reference omits the inclusive endpoint contract documented by Table_CellSelection.getCellSelectionBounds. Add it so consumers do not misread the rectangle boundaries.
Proposed clarification
-Resolves ordered range operations into disjoint, positive display-order
-index rectangles.
+Resolves ordered range operations into disjoint, positive, inclusive
+display-order index rectangles.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Resolves ordered range operations into disjoint, positive display-order | |
| index rectangles. | |
| Resolves ordered range operations into disjoint, positive, inclusive | |
| display-order index rectangles. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/reference/static-functions/functions/table_getCellSelectionBounds.md`
around lines 14 - 15, Update the description of the standalone function
reference for table_getCellSelectionBounds to explicitly state that the returned
index rectangles use inclusive boundaries, matching
Table_CellSelection.getCellSelectionBounds.
| Defined in: [features/cell-selection/cellSelectionFeature.utils.ts:510](https://github.com/TanStack/table/blob/main/packages/table-core/src/features/cell-selection/cellSelectionFeature.utils.ts#L510) | ||
|
|
||
| Returns the active cell, i.e. the anchor of the most recent range. | ||
| Returns the active cell, i.e. the anchor of the most recent operation. |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Document focus on excluded cells.
An exclude operation can leave the focused cell outside the final positive selection. Add this clarification so callers do not assume table_getFocusedCell() always returns a selected cell.
Proposed clarification
Returns the active cell, i.e. the anchor of the most recent operation.
+An exclusion operation can leave the focused cell outside the final positive selection.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Returns the active cell, i.e. the anchor of the most recent operation. | |
| Returns the active cell, i.e. the anchor of the most recent operation. | |
| An exclusion operation can leave the focused cell outside the final positive selection. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/reference/static-functions/functions/table_getFocusedCell.md` at line
16, Update the documentation for table_getFocusedCell to clarify that an exclude
operation may leave the focused cell outside the final positive selection, so
callers must not assume the returned cell is selected.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/framework/solid/guide/cell-selection.md`:
- Line 210: Update the `cell.getIsSelected()` documentation to describe the
resolved selection state: it should indicate whether the cell belongs to the
final positive selection regions, not merely whether it falls within any stored
range, since excluded cells are not selected.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: be9538f8-0aed-4d74-bfc9-bf6ede05dbbd
📒 Files selected for processing (65)
docs/framework/alpine/guide/cell-selection.mddocs/framework/angular/guide/cell-selection.mddocs/framework/ember/guide/cell-selection.mddocs/framework/lit/guide/cell-selection.mddocs/framework/lit/quick-start.mddocs/framework/preact/guide/cell-selection.mddocs/framework/react/guide/cell-selection.mddocs/framework/solid/guide/cell-selection.mddocs/framework/svelte/guide/cell-selection.mddocs/framework/vue/guide/cell-selection.mddocs/reference/index/index.mddocs/reference/index/interfaces/CellSelectionRange.mddocs/reference/index/interfaces/Cell_CellSelection.mddocs/reference/index/interfaces/SelectCellRangeOptions.mddocs/reference/index/interfaces/TableOptions_CellSelection.mddocs/reference/index/interfaces/Table_CellSelection.mddocs/reference/index/type-aliases/CellSelectionRangeMode.mddocs/reference/index/type-aliases/CellSelectionRangeOperation.mddocs/reference/index/type-aliases/CellSelectionState.mddocs/reference/static-functions/functions/cell_getIsFocused.mddocs/reference/static-functions/functions/cell_getIsSelected.mddocs/reference/static-functions/functions/table_getCellSelectionBounds.mddocs/reference/static-functions/functions/table_getFocusedCell.mddocs/reference/static-functions/functions/table_getSelectedCellCount.mddocs/reference/static-functions/functions/table_getSelectedCellRangesData.mddocs/reference/static-functions/functions/table_selectCellRange.mdexamples/alpine/cell-selection/src/main.tsexamples/angular/cell-selection/src/app/app.htmlexamples/angular/cell-selection/src/app/app.tsexamples/lit/basic-app-table/src/main.tsexamples/lit/basic-dynamic-columns/src/main.tsexamples/lit/basic-external-atoms/src/main.tsexamples/lit/basic-external-state/src/main.tsexamples/lit/basic-subscribe/src/main.tsexamples/lit/cell-selection/src/main.tsexamples/lit/column-pinning-sticky/src/main.tsexamples/lit/column-pinning/src/main.tsexamples/lit/column-sizing/src/main.tsexamples/lit/composable-tables/src/components/products-table.tsexamples/lit/composable-tables/src/components/users-table.tsexamples/lit/expanding/src/main.tsexamples/lit/filters-faceted-bucketed/src/main.tsexamples/lit/filters-faceted/src/main.tsexamples/lit/filters-fuzzy/src/main.tsexamples/lit/filters/src/main.tsexamples/lit/grouped-aggregation/src/main.tsexamples/lit/grouping/src/main.tsexamples/lit/kitchen-sink/src/main.tsexamples/lit/row-pinning/src/main.tsexamples/lit/sorting-dynamic-data/src/main.tsexamples/lit/sorting/src/main.tsexamples/lit/virtualized-columns/src/main.tsexamples/preact/cell-selection/src/main.tsxexamples/react/cell-selection/src/main.tsxexamples/react/cell-selection/tests/e2e/smoke.spec.tsexamples/react/spreadsheet/tests/e2e/spreadsheet.spec.tsexamples/solid/cell-selection/src/App.tsxexamples/svelte/cell-selection/src/App.svelteexamples/vue/cell-selection/src/App.vuepackages/table-core/src/features/cell-selection/cellSelectionFeature.types.tspackages/table-core/src/features/cell-selection/cellSelectionFeature.utils.tspackages/table-core/src/features/cell-selection/cellSelectionGeometry.tspackages/table-core/tests/implementation/features/cell-selection/cellSelectionFeature.test.tspackages/table-core/tests/implementation/features/cell-selection/cellSelectionGeometry.test.tspackages/table-core/tests/implementation/features/cell-selection/cellSelectionRange.test.ts
🚧 Files skipped from review as they are similar to previous changes (62)
- docs/framework/lit/quick-start.md
- docs/reference/index/index.md
- examples/lit/column-sizing/src/main.ts
- examples/alpine/cell-selection/src/main.ts
- examples/lit/basic-dynamic-columns/src/main.ts
- docs/reference/index/interfaces/CellSelectionRange.md
- examples/lit/filters-faceted/src/main.ts
- examples/lit/expanding/src/main.ts
- examples/lit/basic-external-state/src/main.ts
- examples/lit/grouped-aggregation/src/main.ts
- docs/reference/index/type-aliases/CellSelectionState.md
- examples/lit/virtualized-columns/src/main.ts
- docs/reference/static-functions/functions/cell_getIsSelected.md
- examples/lit/row-pinning/src/main.ts
- examples/vue/cell-selection/src/App.vue
- examples/lit/column-pinning-sticky/src/main.ts
- examples/lit/column-pinning/src/main.ts
- docs/reference/static-functions/functions/cell_getIsFocused.md
- examples/angular/cell-selection/src/app/app.ts
- docs/reference/index/type-aliases/CellSelectionRangeOperation.md
- examples/lit/filters-faceted-bucketed/src/main.ts
- examples/lit/basic-external-atoms/src/main.ts
- docs/reference/static-functions/functions/table_selectCellRange.md
- examples/lit/sorting-dynamic-data/src/main.ts
- docs/reference/index/interfaces/SelectCellRangeOptions.md
- examples/angular/cell-selection/src/app/app.html
- examples/lit/filters/src/main.ts
- examples/lit/composable-tables/src/components/users-table.ts
- docs/reference/static-functions/functions/table_getCellSelectionBounds.md
- examples/react/spreadsheet/tests/e2e/spreadsheet.spec.ts
- examples/lit/basic-subscribe/src/main.ts
- examples/lit/composable-tables/src/components/products-table.ts
- examples/solid/cell-selection/src/App.tsx
- docs/reference/static-functions/functions/table_getSelectedCellRangesData.md
- examples/lit/grouping/src/main.ts
- examples/lit/sorting/src/main.ts
- docs/reference/static-functions/functions/table_getFocusedCell.md
- examples/react/cell-selection/src/main.tsx
- examples/lit/filters-fuzzy/src/main.ts
- examples/preact/cell-selection/src/main.tsx
- examples/react/cell-selection/tests/e2e/smoke.spec.ts
- examples/lit/cell-selection/src/main.ts
- examples/svelte/cell-selection/src/App.svelte
- packages/table-core/tests/implementation/features/cell-selection/cellSelectionRange.test.ts
- packages/table-core/tests/implementation/features/cell-selection/cellSelectionGeometry.test.ts
- examples/lit/kitchen-sink/src/main.ts
- examples/lit/basic-app-table/src/main.ts
- packages/table-core/tests/implementation/features/cell-selection/cellSelectionFeature.test.ts
- docs/framework/svelte/guide/cell-selection.md
- docs/reference/static-functions/functions/table_getSelectedCellCount.md
- docs/framework/alpine/guide/cell-selection.md
- docs/framework/preact/guide/cell-selection.md
- docs/reference/index/interfaces/TableOptions_CellSelection.md
- docs/framework/vue/guide/cell-selection.md
- docs/framework/lit/guide/cell-selection.md
- docs/framework/ember/guide/cell-selection.md
- docs/reference/index/interfaces/Table_CellSelection.md
- docs/reference/index/interfaces/Cell_CellSelection.md
- docs/framework/react/guide/cell-selection.md
- packages/table-core/src/features/cell-selection/cellSelectionFeature.types.ts
- docs/framework/angular/guide/cell-selection.md
- packages/table-core/src/features/cell-selection/cellSelectionFeature.utils.ts
|
|
||
| TanStack Table does not dictate how you render selected cells. These cell APIs give you everything you need: | ||
|
|
||
| - `cell.getIsSelected()` - whether this cell falls inside any range |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Describe resolved selection state.
An excluded cell falls inside a stored range but is not selected. State that cell.getIsSelected() checks membership in the final positive selection regions.
Proposed fix
-- `cell.getIsSelected()` - whether this cell falls inside any range
+- `cell.getIsSelected()` - whether this cell falls inside a final positive selection region📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - `cell.getIsSelected()` - whether this cell falls inside any range | |
| - `cell.getIsSelected()` - whether this cell falls inside a final positive selection region |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/framework/solid/guide/cell-selection.md` at line 210, Update the
`cell.getIsSelected()` documentation to describe the resolved selection state:
it should indicate whether the cell belongs to the final positive selection
regions, not merely whether it falls within any stored range, since excluded
cells are not selected.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/table-core/skills/migrate-v8-to-v9/SKILL.md`:
- Line 298: Update the migration checklist wording around the stock feature
inventory so it still audits all 16 available features, but instructs
registering only those actually used by the migrated table’s table, row, column,
cell, and header code. Preserve the opt-in nature of v9 features and avoid
requiring unrelated registrations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 5b6c3745-fd95-4c89-a64f-d7f92ed3daad
📒 Files selected for processing (12)
_artifacts/domain_map.yaml_artifacts/skill_spec.md_artifacts/skill_tree.yamlpackages/angular-table/skills/migrate-v8-to-v9/SKILL.mdpackages/lit-table/skills/migrate-v8-to-v9/SKILL.mdpackages/preact-table/skills/migrate-v8-to-v9/SKILL.mdpackages/react-table/skills/migrate-v8-to-v9/SKILL.mdpackages/solid-table/skills/migrate-v8-to-v9/SKILL.mdpackages/svelte-table/skills/migrate-v8-to-v9/SKILL.mdpackages/table-core/skills/cell-selection/SKILL.mdpackages/table-core/skills/migrate-v8-to-v9/SKILL.mdpackages/vue-table/skills/migrate-v8-to-v9/SKILL.md
| - [ ] Replace the v8 adapter constructor/hook/controller with its v9 entrypoint. | ||
| - [ ] Add a stable `features` object to every table. | ||
| - [ ] Inventory every feature API used by table, row, column, cell, and header code; register all 14 required stock features. | ||
| - [ ] Inventory every feature API used by table, row, column, cell, and header code; register all 16 required stock features. |
There was a problem hiding this comment.
🚀 Performance & Scalability | 🟠 Major | ⚡ Quick win
Register only the features used by the migrated table.
Line 298 requires all 16 stock features, but v9 features are opt-in and stockFeatures is documented as an audit bridge. This wording can make migrations register unrelated state and APIs and lose tree-shaking. Change the checklist to audit all 16 features but register only the features used by the code.
Proposed wording
-- [ ] Inventory every feature API used by table, row, column, cell, and header code; register all 16 required stock features.
+- [ ] Inventory every feature API used by table, row, column, cell, and header code; register only the features used by that code, and audit all 16 stock features for migration coverage.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - [ ] Inventory every feature API used by table, row, column, cell, and header code; register all 16 required stock features. | |
| - [ ] Inventory every feature API used by table, row, column, cell, and header code; register only the features used by that code, and audit all 16 stock features for migration coverage. |
🧰 Tools
🪛 SkillSpector (2.4.4)
[warning] 180: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 180: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 182: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 182: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 183: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 184: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
[warning] 234: [MP2] Context Window Stuffing: Skill attempts to fill the context window with filler content, displacing legitimate instructions and safety constraints. This can degrade agent performance or bypass safety boundaries.
Remediation: Implement context-window management that detects and rejects padding or stuffing attempts. Prioritize system instructions over user-injected content.
(Memory Poisoning (MP2))
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/table-core/skills/migrate-v8-to-v9/SKILL.md` at line 298, Update the
migration checklist wording around the stock feature inventory so it still
audits all 16 available features, but instructs registering only those actually
used by the migrated table’s table, row, column, cell, and header code. Preserve
the opt-in nature of v9 features and avoid requiring unrelated registrations.
1 participant
What
Adds ordered include/exclude operations to cell-selection state so consumers can represent selections such as “select all except this region” without rebuilding positive ranges themselves.
CellSelectionRange.operationandselectCellRange({ mode })additiveremains supported as a deprecated compatibility alias formode: 'include'; an explicitmodetakes precedence.This implements the cell-selection model explored in discussion #6473.
Why
Cell-selection state previously described only a union of positive rectangles. Removing an arbitrary rectangle required application code to split and reconstruct ranges. Ordered include/exclude operations keep the controlled state compact while allowing Table to derive the final selection geometry consistently.
Verification
pnpm test— passed all 839 taskspnpm test:skills— validated all 80 skillspnpm test:intent— validation and staleness scan passedpnpm test:docs— passedgit diff --check— passedSummary by CodeRabbit
New Features
Documentation
Tests